From d808585049ab844d134b1311aa40a67503fb0f06 Mon Sep 17 00:00:00 2001 From: josh Date: Thu, 30 Jan 2020 07:11:41 +0000 Subject: [PATCH 1/2] updated pull request --- .github/PULL_REQUEST_TEMPLATE.md | 17 ++++++++++++++--- 1 file changed, 14 insertions(+), 3 deletions(-) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index 2d956bba2..ae9ced739 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -6,11 +6,22 @@ Thanks for submitting a PR! Please fill in this template where appropriate: ## Feature/Issue Description -This module is added to ... +This Module is added to ... +This Extension is used by doing ... +This Bug can be reproduced by ... +The Documentation describes ... +This test covers ... + + +## Describe what changes +Describe how the change affects BeEF's usability ... +Describe how to replicate the issue/bug that this is fixing ... +Describe what this improves ## Test cases - +Describe what the goal of the test is, what it covers and if there are any use cases that still need to be covered. spec/beef/extensions/example_extension.rb ## Relevant wiki page - +If this should be described in a wiki page. +To decide if it is not easily understandable without little pre-knowledge or context, there should be a section in a page somewhere explaining it. From e6d689d90ef20eb3cdf2017257505baeb8e93c58 Mon Sep 17 00:00:00 2001 From: josh Date: Thu, 30 Jan 2020 07:13:15 +0000 Subject: [PATCH 2/2] updated pull request template --- .github/PULL_REQUEST_TEMPLATE.md | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index ae9ced739..27bc46604 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -10,7 +10,7 @@ This Module is added to ... This Extension is used by doing ... This Bug can be reproduced by ... The Documentation describes ... -This test covers ... +This Test covers ... ## Describe what changes @@ -23,5 +23,4 @@ Describe what the goal of the test is, what it covers and if there are any use c spec/beef/extensions/example_extension.rb ## Relevant wiki page -If this should be described in a wiki page. -To decide if it is not easily understandable without little pre-knowledge or context, there should be a section in a page somewhere explaining it. +If it is not easily understandable without little pre-knowledge or context, there should be a section in the Wiki somewhere explaining it.