From 5d7f6372b637ca9ae4611f28405078e61c95c0ad Mon Sep 17 00:00:00 2001 From: zinduolis Date: Fri, 8 Nov 2024 21:14:11 +1000 Subject: [PATCH 1/2] Test gh workflow without approval --- .github/workflows/github_actions.yml | 13 +++---------- 1 file changed, 3 insertions(+), 10 deletions(-) diff --git a/.github/workflows/github_actions.yml b/.github/workflows/github_actions.yml index 7365335cc..adf29abbf 100644 --- a/.github/workflows/github_actions.yml +++ b/.github/workflows/github_actions.yml @@ -1,17 +1,10 @@ name: 'BrowserStack Test' on: - pull_request_target: + pull_request: branches: [ master ] -jobs: - approve: - runs-on: ubuntu-latest - - steps: - - name: Approve - run: echo For security reasons, all pull requests need to be approved first before running any automated CI. - +jobs: ubuntu-job: name: 'BrowserStack Test on Ubuntu' runs-on: ubuntu-latest # Can be self-hosted runner also @@ -34,7 +27,7 @@ jobs: local-identifier: random - name: 'Checkout the repository' - uses: actions/checkout@v2 + uses: actions/checkout@v4 with: ref: ${{ github.event.pull_request.head.sha }} fetch-depth: 2 From 2f4e5fdf09018dddbfcd4a0d8e8f0ae4777b39a3 Mon Sep 17 00:00:00 2001 From: zinduolis Date: Fri, 8 Nov 2024 21:33:08 +1000 Subject: [PATCH 2/2] Production ready github_actions.yml --- .github/workflows/github_actions.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/github_actions.yml b/.github/workflows/github_actions.yml index adf29abbf..5182fe894 100644 --- a/.github/workflows/github_actions.yml +++ b/.github/workflows/github_actions.yml @@ -1,7 +1,7 @@ name: 'BrowserStack Test' on: - pull_request: + pull_request_target: branches: [ master ] jobs: