From 59c34d5697f4df919354d13a0b5b85aca90a9469 Mon Sep 17 00:00:00 2001 From: Jack Walker Date: Wed, 29 Apr 2020 13:26:20 +1000 Subject: [PATCH] Adding some handling for potential issue in BeEF recognising hooks --- spec/beef/core/main/autorun_engine/autorun_engine_spec.rb | 4 ---- .../beef/core/main/handlers/browser_details_handler_spec.rb | 6 +++++- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/spec/beef/core/main/autorun_engine/autorun_engine_spec.rb b/spec/beef/core/main/autorun_engine/autorun_engine_spec.rb index d10fb8b6d..cf56913bc 100644 --- a/spec/beef/core/main/autorun_engine/autorun_engine_spec.rb +++ b/spec/beef/core/main/autorun_engine/autorun_engine_spec.rb @@ -113,13 +113,9 @@ RSpec.describe 'AutoRunEngine Test', :run_on_browserstack => true do end it 'AutoRunEngine is working' do - puts @hooks['hooked-browsers']['online'] - puts @hooks['hooked-browsers']['online'].empty? if @hooks['hooked-browsers']['online'].empty? - puts 'in browser block' expect(BeEF::Filters.is_valid_hook_session_id?(@driver.execute_script("return window.beef.session.get_hook_session_id()"))).to eq true else - puts 'in api block' expect(@hooks['hooked-browsers']['online']).not_to be_empty end end diff --git a/spec/beef/core/main/handlers/browser_details_handler_spec.rb b/spec/beef/core/main/handlers/browser_details_handler_spec.rb index 789801943..542933615 100644 --- a/spec/beef/core/main/handlers/browser_details_handler_spec.rb +++ b/spec/beef/core/main/handlers/browser_details_handler_spec.rb @@ -110,7 +110,11 @@ RSpec.describe 'Browser Details Handler', :run_on_browserstack => true do end it 'can successfully hook a browser' do - expect(@hooks['hooked-browsers']['online']).not_to be_empty + if @hooks['hooked-browsers']['online'].empty? + expect(BeEF::Filters.is_valid_hook_session_id?(@driver.execute_script("return window.beef.session.get_hook_session_id()"))).to eq true + else + expect(@hooks['hooked-browsers']['online']).not_to be_empty + end end it 'browser details handler working' do