From 822bd614261082b52e19329182b5d44483b7a7c8 Mon Sep 17 00:00:00 2001 From: Jack Walker Date: Wed, 29 Apr 2020 11:14:28 +1000 Subject: [PATCH] Testing new client side wait to increase hook consistency in test. --- spec/beef/core/main/autorun_engine/autorun_engine_spec.rb | 2 +- spec/beef/core/main/handlers/browser_details_handler_spec.rb | 2 +- spec/beef/modules/debug/test_beef_debugs_spec.rb | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/spec/beef/core/main/autorun_engine/autorun_engine_spec.rb b/spec/beef/core/main/autorun_engine/autorun_engine_spec.rb index f23262f8f..8e3495183 100644 --- a/spec/beef/core/main/autorun_engine/autorun_engine_spec.rb +++ b/spec/beef/core/main/autorun_engine/autorun_engine_spec.rb @@ -94,7 +94,7 @@ RSpec.describe 'AutoRunEngine Test', :run_on_browserstack => true do # Give time for browser hook to occur wait = Selenium::WebDriver::Wait.new(:timeout => 30) # seconds - wait.until { @driver.execute_script("return window.beef.session.get_hook_session_id().length").greater_than 0} + wait.until { @driver.execute_script("return window.beef.session.get_hook_session_id().length") > 0} puts @driver.execute_script("return window.beef.session.get_hook_session_id()") @hooks = JSON.parse(RestClient.get "#{RESTAPI_HOOKS}?token=#{@token}") diff --git a/spec/beef/core/main/handlers/browser_details_handler_spec.rb b/spec/beef/core/main/handlers/browser_details_handler_spec.rb index 326fb1177..9b5b93044 100644 --- a/spec/beef/core/main/handlers/browser_details_handler_spec.rb +++ b/spec/beef/core/main/handlers/browser_details_handler_spec.rb @@ -91,7 +91,7 @@ RSpec.describe 'Browser Details Handler', :run_on_browserstack => true do # Give time for browser hook to occur wait = Selenium::WebDriver::Wait.new(:timeout => 30) # seconds - wait.until { @driver.execute_script("return window.beef.session.get_hook_session_id().length").greater_than 0} + wait.until { @driver.execute_script("return window.beef.session.get_hook_session_id().length") > 0} puts @driver.execute_script("return window.beef.session.get_hook_session_id()") @hooks = JSON.parse(RestClient.get "#{RESTAPI_HOOKS}?token=#{@token}") diff --git a/spec/beef/modules/debug/test_beef_debugs_spec.rb b/spec/beef/modules/debug/test_beef_debugs_spec.rb index fed7c3dc5..f1903cbb5 100644 --- a/spec/beef/modules/debug/test_beef_debugs_spec.rb +++ b/spec/beef/modules/debug/test_beef_debugs_spec.rb @@ -90,7 +90,7 @@ RSpec.describe 'BeEF Debug Command Modules:', :run_on_browserstack => true do # Give time for browser hook to occur wait = Selenium::WebDriver::Wait.new(:timeout => 30) # seconds - wait.until { @driver.execute_script("return window.beef.session.get_hook_session_id().length").greater_than 0} + wait.until { @driver.execute_script("return window.beef.session.get_hook_session_id().length") > 0} puts @driver.execute_script("return window.beef.session.get_hook_session_id()") @hooks = JSON.parse(RestClient.get "#{RESTAPI_HOOKS}?token=#{@token}")