From a85f0d78d04ec6ae2c84795c97da24efec9b6f85 Mon Sep 17 00:00:00 2001 From: Jack Walker Date: Fri, 15 May 2020 13:09:09 +1000 Subject: [PATCH] Reversed logic gate for incorrectly handled exception. --- spec/beef/core/main/autorun_engine/autorun_engine_spec.rb | 2 +- spec/beef/core/main/handlers/browser_details_handler_spec.rb | 2 +- spec/beef/extensions/websocket_hooked_browser_spec.rb | 2 +- spec/beef/modules/debug/test_beef_debugs_spec.rb | 3 ++- 4 files changed, 5 insertions(+), 4 deletions(-) diff --git a/spec/beef/core/main/autorun_engine/autorun_engine_spec.rb b/spec/beef/core/main/autorun_engine/autorun_engine_spec.rb index ba8155e57..53fa0024d 100644 --- a/spec/beef/core/main/autorun_engine/autorun_engine_spec.rb +++ b/spec/beef/core/main/autorun_engine/autorun_engine_spec.rb @@ -102,7 +102,7 @@ RSpec.describe 'AutoRunEngine Test', :run_on_browserstack => true do begin @hook_request = RestClient.get "#{RESTAPI_HOOKS}?token=#{@token}" @hooks = JSON.parse(@hook_request) - if @hooks['hooked-browsers']['online'].empty? + unless @hooks['hooked-browsers']['online'].empty? @session = @hooks['hooked-browsers']['online']['0']['session'] else print_info "Cannot find online session server-side" diff --git a/spec/beef/core/main/handlers/browser_details_handler_spec.rb b/spec/beef/core/main/handlers/browser_details_handler_spec.rb index 16aece581..2ed0ef9a3 100644 --- a/spec/beef/core/main/handlers/browser_details_handler_spec.rb +++ b/spec/beef/core/main/handlers/browser_details_handler_spec.rb @@ -99,7 +99,7 @@ RSpec.describe 'Browser Details Handler', :run_on_browserstack => true do begin @hook_request = RestClient.get "#{RESTAPI_HOOKS}?token=#{@token}" @hooks = JSON.parse(@hook_request) - if @hooks['hooked-browsers']['online'].empty? + unless @hooks['hooked-browsers']['online'].empty? @session = @hooks['hooked-browsers']['online']['0']['session'] else print_info "Cannot find online session server-side." diff --git a/spec/beef/extensions/websocket_hooked_browser_spec.rb b/spec/beef/extensions/websocket_hooked_browser_spec.rb index d5478a414..616b0c0ce 100644 --- a/spec/beef/extensions/websocket_hooked_browser_spec.rb +++ b/spec/beef/extensions/websocket_hooked_browser_spec.rb @@ -88,7 +88,7 @@ RSpec.describe 'Browser hooking with Websockets', :run_on_browserstack => true d begin @hook_request = RestClient.get "#{RESTAPI_HOOKS}?token=#{@token}" @hooks = JSON.parse(@hook_request) - if @hooks['hooked-browsers']['online'].empty? + unless @hooks['hooked-browsers']['online'].empty? @session = @hooks['hooked-browsers']['online']['0']['session'] else print_info "Cannot find online session server-side." diff --git a/spec/beef/modules/debug/test_beef_debugs_spec.rb b/spec/beef/modules/debug/test_beef_debugs_spec.rb index 0d4309b49..a2bb1124a 100644 --- a/spec/beef/modules/debug/test_beef_debugs_spec.rb +++ b/spec/beef/modules/debug/test_beef_debugs_spec.rb @@ -98,7 +98,7 @@ RSpec.describe 'BeEF Debug Command Modules:', :run_on_browserstack => true do begin @hook_request = RestClient.get "#{RESTAPI_HOOKS}?token=#{@token}" @hooks = JSON.parse(@hook_request) - if @hooks['hooked-browsers']['online'].empty? + unless @hooks['hooked-browsers']['online'].empty? @session = @hooks['hooked-browsers']['online']['0']['session'] else print_info "Cannot find online session server-side." @@ -126,6 +126,7 @@ RSpec.describe 'BeEF Debug Command Modules:', :run_on_browserstack => true do rescue => exception if exception.class == NoMethodError && exception.message.include?('Failed to open TCP connection') print_info "Encountered possible false negative timeout error checking exception." + expect(exception).to include('hub-cloud.browserstack.com:80') else print_info "Error closing BrowserStack connection: #{exception}" end