From e10e921e51284b41e25a176fa67783e3ec31f1c4 Mon Sep 17 00:00:00 2001 From: "wade@bindshell.net" Date: Thu, 20 Jan 2011 21:03:16 +0000 Subject: [PATCH] Actionable TODOs move to the tracker. TODOs have been removed from source. git-svn-id: https://beef.googlecode.com/svn/trunk@703 b87d56ec-f9c0-11de-8c8a-61c5e9addfc9 --- lib/filter/base.rb | 1 - lib/server/httphookserver.rb | 1 - lib/server/modules/common.rb | 2 +- lib/ui/authentication/authentication.rb | 1 - lib/ui/panel/panel.rb | 5 +---- modules/commands/misc/raw_javascript/raw_javascript.rb | 1 - public/javascript/ui/panel/zombiesTreeList.js | 1 - 7 files changed, 2 insertions(+), 10 deletions(-) diff --git a/lib/filter/base.rb b/lib/filter/base.rb index 62a78b3ea..b6c1cca95 100644 --- a/lib/filter/base.rb +++ b/lib/filter/base.rb @@ -72,7 +72,6 @@ module BeEF end # check if valid ip address string - # TODO add unit tests def self.is_valid_ip?(ip) return true if ip =~ /^(\d{1,3}\.\d{1,3}\.\d{1,3}\.\d{1,3})?$/ false diff --git a/lib/server/httphookserver.rb b/lib/server/httphookserver.rb index 9d6241f71..9cb30ba41 100644 --- a/lib/server/httphookserver.rb +++ b/lib/server/httphookserver.rb @@ -75,7 +75,6 @@ module BeEF command_class = (File.basename command, '.rb').capitalize command_file = (File.basename command, '.rb')+'.js' - #TODO: implement URL obfuscation at start up. @http_server.mount "/command/#{command_file}", BeEF::CommandHandler, command_class } diff --git a/lib/server/modules/common.rb b/lib/server/modules/common.rb index 2436399e1..ba1a598ea 100644 --- a/lib/server/modules/common.rb +++ b/lib/server/modules/common.rb @@ -132,7 +132,7 @@ module Modules # Executes every plugins in the framework. # def execute_plugins! - #TODO + end end diff --git a/lib/ui/authentication/authentication.rb b/lib/ui/authentication/authentication.rb index f3789b216..9f38c6033 100644 --- a/lib/ui/authentication/authentication.rb +++ b/lib/ui/authentication/authentication.rb @@ -71,7 +71,6 @@ class Authentication < BeEF::HttpController # add session cookie to response header @headers['Set-Cookie'] = session_cookie.to_s - # TODO add escape username and password submitted BeEF::Logger.instance.register('Authentication', "User with ip #{@request.peeraddr[3]} has successfuly authenticated in the application.") @body = "{ success : true }" end diff --git a/lib/ui/panel/panel.rb b/lib/ui/panel/panel.rb index 0eeb1418a..6048a528a 100644 --- a/lib/ui/panel/panel.rb +++ b/lib/ui/panel/panel.rb @@ -48,12 +48,9 @@ class Panel < BeEF::HttpController # Takes a list distributed engine rules and format the results into JSON def distributed_engine_rules_2_json_simple(rules) - #TODO + end -# TODO: we have duplicate functions here (see ui/zombies/zombies.rb), maybe we need to -# organize the code differently. - # Takes a list of zombies and format the results in a JSON array. def zombies2json_simple(zombies) zombies_hash = {} diff --git a/modules/commands/misc/raw_javascript/raw_javascript.rb b/modules/commands/misc/raw_javascript/raw_javascript.rb index 3eddcf95e..f54f349f5 100644 --- a/modules/commands/misc/raw_javascript/raw_javascript.rb +++ b/modules/commands/misc/raw_javascript/raw_javascript.rb @@ -1,4 +1,3 @@ -#TODO: review when multi zombie hooks are available module BeEF module Modules module Commands diff --git a/public/javascript/ui/panel/zombiesTreeList.js b/public/javascript/ui/panel/zombiesTreeList.js index a81dad3ac..d864b3d6f 100644 --- a/public/javascript/ui/panel/zombiesTreeList.js +++ b/public/javascript/ui/panel/zombiesTreeList.js @@ -261,6 +261,5 @@ Ext.extend(zombiesTreeList, Ext.tree.TreePanel, { //we return if the tree is not distributed if(!this.tree_configuration["distributed"]) return; - //TODO } }); \ No newline at end of file