fix(ci): give the smoke-test container a per-commit name #68

Merged
Latte merged 1 commits from fix/smoke-test-container-name into dev 2026-07-05 12:00:27 +00:00

The Docker smoke-test started the server container under the fixed name familiar-smoke. On the self-hosted runner the job shares the host Docker daemon, so a container left behind by a killed or re-run job (or a concurrent dev push + PR) collides on that name and docker run fails with exit 125 — the "container name /familiar-smoke is already in use" error seen when merging dev → main.

Fix:

  • Derive the container name from the commit SHA (familiar-smoke-<sha12>) via the meta step, so concurrent/parallel runs no longer share a name.
  • docker rm -f any stale container of that name before starting (covers re-runs of the same commit).
  • Thread the name through the smoke-test and cleanup steps.

No behavioural change to the actual smoke checks.

The Docker smoke-test started the server container under the fixed name `familiar-smoke`. On the self-hosted runner the job shares the host Docker daemon, so a container left behind by a killed or re-run job (or a concurrent `dev` push + PR) collides on that name and `docker run` fails with exit 125 — the "container name /familiar-smoke is already in use" error seen when merging `dev` → `main`. **Fix:** - Derive the container name from the commit SHA (`familiar-smoke-<sha12>`) via the `meta` step, so concurrent/parallel runs no longer share a name. - `docker rm -f` any stale container of that name before starting (covers re-runs of the same commit). - Thread the name through the smoke-test and cleanup steps. No behavioural change to the actual smoke checks.
Ghost added 1 commit 2026-07-05 11:56:01 +00:00
fix(ci): give the smoke-test container a per-commit name
CI / lint (pull_request) Successful in 55s
docker / lint (pull_request) Successful in 56s
CI / test (pull_request) Successful in 1m6s
docker / test (pull_request) Successful in 1m4s
CI / publish (pull_request) Has been skipped
docker / docker (pull_request) Successful in 41s
288c696f28
The Docker smoke-test ran the server container under the fixed name
familiar-smoke. On the self-hosted runner the job shares the host
Docker daemon, so a container left behind by a killed or re-run job
(or a concurrent dev push + PR) collides on that name and 'docker run'
fails with exit 125.

Derive the name from the commit SHA, remove any stale container of that
name before starting, and thread the name through the smoke-test and
cleanup steps.
Latte merged commit d69c994da0 into dev 2026-07-05 12:00:27 +00:00
Latte deleted branch fix/smoke-test-container-name 2026-07-05 12:00:28 +00:00
Sign in to join this conversation.
No Reviewers
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Hiddenden/familiar#68